refactor: use native Node glob APIs#1234
Conversation
🦋 Changeset detectedLatest commit: 56fd68a The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
commit: |
vicb
left a comment
vicb
left a comment
There was a problem hiding this comment.
Thanks for the PR!
What is the minimal version of Node required?
Please answer the question in the PR description and by adding an engines entry in package.json
Also please do not change async <> sync if there is no good reason to do so - if there are please do that in a follow up PR explaining the rationale in the description
| @@ -0,0 +1,7 @@ | |||
| --- | |||
There was a problem hiding this comment.
We do not really need a changeset for that if there are no user facing change
There was a problem hiding this comment.
I think there are no changes facing users directly.
However, since this PR defines engines, I thought it should be submitted as a patch.
https://nodejs.org/api/fs.html#fspromisesglobpattern-options Added in: v22.0.0
v22.17.0 (or v24.1.0) is. Node v20 is reaching EOL soon (April 2026), so I think we can safely drop support for it. |
If I recall correctly, I believe the plan was for the minimum Node version to be bumped as part of the next major. The AWS adapter still supports Node.js v20 as well. For what it's worth, many companies will use a Node.js version right up until it EOLs, and continue using it beyond that. |
Good point @james-elicx. I'll move this PR to draft for now. |
|
(Note: Node 20 is now EOL) |
|
I can confirm what @james-elicx is saying. One of the companies I work for are still using Node v20 in AWS Lambdas even though it has reached end of support recently. Looking in AWS docs I see that we should probably update soon. 
|
4 participants
Use Node.js native glob APIs for cache population and build-time patch discovery instead of the
globpackage. This keeps path handling based on explicit working directories and removes the directglobdependency.